Tx track modif 7087 v14 #11915
Tx track modif 7087 v14 #11915
Conversation
To optimize detection, and logging, to avoid going through all the live transactions when only a few were modified. Ticket: 7087
Completes Ticket 7013
catenacyber
requested review from
jufajardini,
victorjulien and
jasonish
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11915 +/- ##
==========================================
- Coverage 82.60% 79.18% -3.42%
==========================================
Files 912 912
Lines 249342 249006 -336
==========================================
- Hits 205968 197179 -8789
- Misses 43374 51827 +8453
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 23069 |
| @@ -155,6 +159,7 @@ impl AppLayerTxData { | |||
| file_flags: 0, | |||
| file_tx: 0, | |||
| stream_logged: 0, | |||
| updated: [true; 2], | |||
There was a problem hiding this comment.
creating a new tx should not lead to it being updated in both dirs? Just in the dir it was created in?
There was a problem hiding this comment.
right, will optimize
| @@ -200,6 +200,7 @@ impl TemplateState { | |||
| start = rem; | |||
|
|
|||
| if let Some(tx) = self.find_request() { | |||
| tx.tx_data.updated[1] = true; | |||
There was a problem hiding this comment.
I don't really like this indexing with just a number to indicate a direction. Can we either index by some name or use something like updated_ts / updated_tc
There was a problem hiding this comment.
Guess I will go for updated_ts as it is used in other parts of the code
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7087
Describe changes:
#11912 with ftp-data using
updatedand trying to be smarter with some protocols only updating the right direction